Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project toml and add uv to build #153

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Add project toml and add uv to build #153

wants to merge 28 commits into from

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Nov 27, 2024 •
edited
Loading

Description

Fixed

  • Changed setup and build engine to uv with hatchling

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@dnil dnil marked this pull request as ready for review November 27, 2024 16:27
@dnil
Copy link
Collaborator Author

dnil commented Nov 27, 2024

I totally expect you to read all 107 files, but most of that is just the introduction of code formatting.
The salient change is that setup.py+requirements.txt is replaced with pyproject.toml+.python-version. This is then reflected in actions and docker files. I picked uv over poetry mostly because uv is fresh and fast; I had some early bad experiences with poetry which I'm sure has matured quite considerably. Still slower though. 😉

@dnil
Copy link
Collaborator Author

dnil commented Nov 27, 2024 •
edited
Loading

I left the linting suggestions for another day (#154). Most of them are straightforward ("use in for testing None"), so mostly laziness. And a little for granularity of changes. This is a lot already.

@dnil dnil marked this pull request as draft November 28, 2024 09:32
@dnil
Copy link
Collaborator Author

dnil commented Nov 28, 2024

Leaving these lint issues, as I have a suspicion they could possibly affect the compound scoring issue, just to have a good baseline for that part.
Screenshot 2024-11-28 at 17 35 02

@dnil dnil marked this pull request as ready for review November 28, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint issues Use uv
1 participant
@dnil